Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to start on some Windows machines #286

Closed
djs55 opened this issue Sep 15, 2017 · 1 comment
Closed

Failure to start on some Windows machines #286

djs55 opened this issue Sep 15, 2017 · 1 comment

Comments

@djs55
Copy link
Collaborator

djs55 commented Sep 15, 2017

A small number users report that vpnkit won't start unless they run it as Administrator. The problem was introduced somewhere in #262 which is unfortunately a large PR. We need to generate some test builds with aspects of it reverted to try to narrow down the cause.
djs55 added a commit to djs55/vpnkit that referenced this issue Sep 15, 2017
@djs55
AUTO: Update upstream packages
26e99db 
(actually this is a manual downgrade to test something so do not
merge this PR)

Related to moby#286

Signed-off-by: David Scott <dave@recoil.org>
This was referenced Sep 15, 2017
Closed
Merged
djs55 added a commit to djs55/vpnkit that referenced this issue Sep 17, 2017
@djs55
ICMP: don't fail to start if we can't create a socket
420e93b 
On some systems the creation of a user-space ICMP socket will fail
with EPERM. If this happens, don't block startup; instead log a message
explaining that ping won't work and continue.

Fixes moby#286

Signed-off-by: David Scott <dave.scott@docker.com>
@djs55 djs55 mentioned this issue Sep 17, 2017
Merged
@djs55
Copy link
Collaborator Author

djs55 commented Sep 17, 2017

Adding some debug on a machine with a repro highlights the user-space ICMP socket -- on the buggy system the socket call fails with EPERM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djs55