-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip binary modules during cache reset #101
Conversation
Good job! Would you mind writing a test for this case? |
Thanks! No problem, but I have doubts about implementation: good test should use binary module, so we need to find it somewhere. Add something "small & binary" to Any suggestion? |
Compiling our own module for this case seems to be a bit more fair, but unfortunately I'm not familiar with it. If it doesn't take a lot of time for you, it would be great. If it does, just add a small/existing binary module to devDependencies. |
Here it is. |
Yes, AWS can interfere in tests results. Let's just wait for tomorrow. |
Test passes on all node.js versions except 'stable' 7.7.0, which was released today (2017-03-01). |
Node.js released fixed stable version, could you please restart Travis build? |
Nice one! Will release a new version today/tomorrow. |
#100