Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip binary modules during cache reset #101

Merged
merged 4 commits into from
Mar 2, 2017
Merged

skip binary modules during cache reset #101

merged 4 commits into from
Mar 2, 2017

Conversation

kolontsov
Copy link
Contributor

@1999
Copy link
Collaborator

1999 commented Feb 21, 2017

Good job! Would you mind writing a test for this case?

@kolontsov
Copy link
Contributor Author

Thanks! No problem, but I have doubts about implementation: good test should use binary module, so we need to find it somewhere. Add something "small & binary" to devDependancies? Or compile own minimal 3-line module from source (it will require installing node-gyp npm)..

Any suggestion?

@1999
Copy link
Collaborator

1999 commented Feb 22, 2017

Add something "small & binary" to devDependancies

Compiling our own module for this case seems to be a bit more fair, but unfortunately I'm not familiar with it. If it doesn't take a lot of time for you, it would be great. If it does, just add a small/existing binary module to devDependencies.

@kolontsov
Copy link
Contributor Author

kolontsov commented Feb 28, 2017

Here it is. npm install && npm test works locally, but travis build below failed without details (I guess they're not completely recovered from AWS outage yet). What I'm supposed to do? upd logs are available, checking.

@1999
Copy link
Collaborator

1999 commented Mar 1, 2017

Yes, AWS can interfere in tests results. Let's just wait for tomorrow.

@kolontsov
Copy link
Contributor Author

Test passes on all node.js versions except 'stable' 7.7.0, which was released today (2017-03-01).
They completely broke compiling addons: nodejs/node#11628. Waiting for a fix.

@kolontsov
Copy link
Contributor Author

Node.js released fixed stable version, could you please restart Travis build?

@1999
Copy link
Collaborator

1999 commented Mar 2, 2017

Nice one! Will release a new version today/tomorrow.

@1999 1999 merged commit 17e70fb into mocha-parallel:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants