fix runner to emit start/end event (#3395)

Signed-off-by: Outsider <outsideris@gmail.com>
mochajs · Nov 2, 2018 · 00ca06b · 00ca06b
1 parent 3e77008
commit 00ca06b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/runner.js b/lib/runner.js
@@ -851,10 +851,15 @@ Runner.prototype.run = function(fn) {
       filterOnly(rootSuite);
     }
     self.started = true;
-    self.emit('start');
+    Runner.immediately(function() {
+      self.emit('start');
+    });
+
     self.runSuite(rootSuite, function() {
       debug('finished running');
-      self.emit('end');
+      Runner.immediately(function() {
+        self.emit('end');
+      });
     });
   }
 

diff --git a/test/unit/mocha.spec.js b/test/unit/mocha.spec.js
@@ -34,6 +34,16 @@ describe('Mocha', function() {
         });
       }
     );
+
+    it('should emit start event', function(done) {
+      var mocha = new Mocha(blankOpts);
+      mocha.run().on('start', done);
+    });
+
+    it('should emit end event', function(done) {
+      var mocha = new Mocha(blankOpts);
+      mocha.run().on('end', done);
+    });
   });
 
   describe('.addFile()', function() {