ci: ensure they all scripts can use npm run

See also #5128
mochajs · Jul 15, 2024 · 00e7681 · 00e7681
1 parent 3544feb
commit 00e7681
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/mocha.yml b/.github/workflows/mocha.yml
@@ -29,7 +29,7 @@ jobs:
     uses: ./.github/workflows/npm-script.yml
     with:
       browsers: ChromeHeadless
-      npm-script: test.browser
+      npm-script: test:browser
 
   test-browser-saucelabs:
     # Don't run forked 'pull_request' without saucelabs token
@@ -41,7 +41,7 @@ jobs:
     secrets: inherit
     with:
       browsers: 'firefox@latest,chrome@latest,MicrosoftEdge@latest,safari@latest'
-      npm-script: test.browser
+      npm-script: test:browser
 
   test-node:
     name: 'Node.js [v${{ matrix.node }} / ${{ matrix.os }}]'

diff --git a/.github/workflows/npm-script.yml b/.github/workflows/npm-script.yml
@@ -63,7 +63,7 @@ jobs:
           node-version: ${{ matrix.node_version }}
           cache: 'npm'
       - run: npm ci --ignore-scripts
-      - run: npm start ${{ inputs.npm-script }}
+      - run: npm run ${{ inputs.npm-script }}
         env:
           BROWSER: ${{ matrix.browser }}
           SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}

diff --git a/package.json b/package.json
@@ -48,6 +48,7 @@
     "start": "nps",
     "test": "nps test",
     "version": "nps version",
+    "test:browser": "nps test.browser",
     "test:smoke": "node ./bin/mocha --no-config test/smoke/smoke.spec.js"
   },
   "dependencies": {