Fix test running output truncation on async STDIO #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test this unless someone beats me to it |
|
ping |
|
Yes, sorry. It's on my list. |
|
It's no problem :) I was just going through all the forks in my account yester to clean them out, haha :D |
|
+1 |
travisjeffery
pushed a commit
that referenced
this pull request
Jan 13, 2015
Fix test running output truncation on async STDIO
|
Thanks |
johanneswuerbach
added a commit
to johanneswuerbach/testem
that referenced
this pull request
Feb 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #333
Note: this does not address the issues with
mocha interfacesand other non-test commands, because if we actually waited for the output to get flushed, the defaultmochaaction (running tests) would start to occur. Refactoring needs to happen to fix this.But this solves the output being cut when the STDIO is async, which is the main use-case.