Ignore asynchronous failures after spec resolution #1578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on #1540 From that thread:
Given the following test, which only has one spec:
You get two two failures:
But after this PR, it correctly only shows one failure, and highlights the error thrown first ("global error"):
In addition to the above fix, this PR improves on #1540 by also correctly handling the following test case:
It now also only reports a single failing spec, rather than two.