fix emit "pending" when running pending test #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1706. `Runnable.run(fn)` wasn't passing an instance of `Pending` to the callback when a `pending` test was ran. Therefore, `Runner` was not firing a "pending" event. Added a test which currently fails due to the `skippedTest`: `[TypeError: Object #<Object> has no method 'skip']`. How does one skip the current running test synchronously?
|
I forgot there was work pending on this one. Adding to my to-do list. |
jbnicolai
force-pushed
the
master
branch
3 times, most recently
from
2f458ab to
2952eca
Compare
|
This is a valid issue - however, this PR has been inactive for a very long time. Let's revisit if we see a need. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1706.
Runnable.run(fn)wasn't passing an instance ofPendingto thecallback when a
pendingtest was ran. Therefore,Runnerwas notfiring a "pending" event.
Added a test which currently fails due to the
skippedTest:[TypeError: Object #<Object> has no method 'skip']. How doesone skip the current running test synchronously?
Also: why are we throwing a
Pendinginstance? Couldn't we setpending = truein.skip(), and then checktest.pendingagain at https://github.com/mochajs/mocha/blob/master/lib/runner.js#L475 ?