-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build mochajs.org with Jekyll; closes #1640 #1726
Conversation
I'm not sure why it doesn't want to merge automatically. This is rebased on top of 5e1fabd |
somebody (not me) needs to look thru the demo site for problems. |
ping @jbnicolai |
I'll have a go ;) |
ping! any updates here? :) |
Lots of stuff here, but the main things: - use Jekyll - convert `index.md` to *actual GFM Markdown* - a lot of edits of the documentation, including, but not limited to: - reorganization - grammar fixes - code style fixes - rewording confusing sentences - add a couple more examples - dynamically generate TOC - use CDNs for JS, though there's basically none I've taken every effort to make the site look as close to the current version as it does now, and keep it compatible with old browsers. However, I was not able to reuse the syntax highlighting scheme, as highlighting is now done by Pygments. ![screenshot 1](http://content.screencast.com/users/chiller/folders/Jing/media/32a9e9d6-b927-465a-a027-39d8bbfe0407/00000153.png) ![screenshot 2](http://content.screencast.com/users/chiller/folders/Jing/media/890e0481-65a4-4729-bc69-37098c48940f/00000154.png)
I've updated this PR:
The only stylistic difference that I can see is that the syntax highlighting isn't the same (imo, it's better). Of course, there's all the changes to the actual documentation and code examples itself, too. @rstacruz Sorry about this; one of us is going to have to throw out work. |
cc @jbnicolai |
http://boneskull.com/mocha/#-w-watch seems broken in the TOC (should have two dashes between 'w' and 'watch) |
Closes mochajs#1640 Closes mochajs#1657 Closes mochajs#1726 Closes mochajs#1729 Closes mochajs#1777
@jbnicolai that's odd... why would you see two levels of nesting? |
@jbnicolai I know why. because I didn't rebase into my gh-pages branch. |
@jbnicolai you may wish to try to build the site yourself as well. but anyway, I updated boneskull.com/mocha with the new code. |
@boneskull I have, see http://blog.jbnicolai.com/mocha/ I suggest we go with #1777 though, as it includes both your branch, the competing branch and some additional changes :) |
@jbnicolai Yes, let's go with your code anyway. |
Demo
Lots of stuff here, but the main things:
index.md
to actual GFM MarkdownI've taken every effort to make the site look as close to the current version as it does now, and keep it compatible with old browsers. However, I was not able to reuse the syntax highlighting scheme, as highlighting is now done by Pygments.