-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace __proto__ references with inherits module #1753
Conversation
I think I'd rather go with LoDash here, since there's going to be a ton of other shims we can replace it with. @mochajs/mocha thoughts? |
@boneskull Which lodash function would you use here? |
a7cf327
to
d5ddcdc
Compare
@boneskull Refactored this to use |
@ndhoule why do you feel it's less expressive? |
2f458ab
to
2952eca
Compare
@nathanboktae I agree On the other hand, since we're intending to go with lodash anyways, I say we merge this version :) Perhaps to make this a bit nicer we could refactor it into a utility method in function inherit(prototype, constructor) {
return create(prototype, {
constructor: constructor
});
} But no strong feelings about that. |
haha pretty much exactly what @jbnicolai said, but really I don't care—I say merge it as is, it's certainly better than the |
Agree, still a huge improvement 👍 |
Replace __proto__ references with inherits module
cc @boneskull @jbnicolai
Resolves #1728.
Depends on merging #1727 because it pulls in an npm dependency; uses style from #1750