fix custom comiler file (absolute path) support in windows system #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silentcloud thanks! |
| var compiler = c.split(':') | ||
| , ext = compiler[0] | ||
| , mod = compiler[1]; | ||
| var compiler = c.match(/([a-z.]+):(([A-Z]:)?\S*)+/) |
There was a problem hiding this comment.
there are several problems with this regular expression--instead, try c.split(':', 1). does that work?
There was a problem hiding this comment.
var str = 'js:C:\\Users\\fortest\\example\\compiler.js';
console.log(str.split(':', 1))
//['js']There was a problem hiding this comment.
right, it still splits, just doesn't return it. how about just:
var idx = c.indexOf(':');
var ext = c.slice(0, idx);
var mod = c.slice(idx + 1);There was a problem hiding this comment.
"slice" is better, I will update this PR
|
Looks good to me. |
|
@boneskull merge & publish a version ？ |
|
@silentcloud not sure when the release will be but I can merge this. thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocha --compilers js:C:\User\fortest\demo\compiler.js#2310