Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add working wallaby config #3224

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

ArtemGovorov
Copy link
Contributor

Description of the Change

Added Wallaby config file as discussed at wallabyjs/public#1490 (comment).

Alternate Designs

n/a

Why should this be in core?

n/a

Benefits

Mocha contributors who are using Wallaby can continuously run mocha tests.

Possible Drawbacks

n/a

Applicable issues

n/a

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.032% when pulling 5f3bb24 on ArtemGovorov:patch-2 into d975a6a on mochajs:master.

@boneskull
Copy link
Contributor

😍 awesome, can't wait to try this. thanks @ArtemGovorov

Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPLENDID

// to expose it/describe etc. on the mocha under test
const mochaUnderTest = new (require('./'))();
mochaUnderTest.suite.emit('pre-require', global, '', mochaUnderTest);
// to make test/node-unit/color.spec.js pass, we need to run mocha in the project's folder context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtemGovorov how did you figure this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had been reading mocha source code and discovered it. Wallaby uses mocha a bit differently from how mocha CLI is using mocha :)

@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 8, 2018
@boneskull boneskull merged commit 44aae9f into mochajs:master Feb 8, 2018
@boneskull boneskull added this to the next milestone Feb 8, 2018
@boneskull boneskull modified the milestones: next, v5.0.1 Mar 6, 2018
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants