-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: use dynamic import to load es module tests. #3253
Commits on Feb 26, 2018
-
Adds flag --es-modules to dynamically import test files.
When the --es-modules flag is provided import() will be used to load all test files.
Configuration menu - View commit details
-
Copy full SHA for d46d557 - Browse repository at this point
Copy the full SHA d46d557View commit details -
Add .js extension to bin/_mocha to get tests passing
node 9.6 will not allow script files without .js extensions when --experimental-modules flag is passed. I think node 9.7 will allow this so this commit can be reverted then.
Configuration menu - View commit details
-
Copy full SHA for a7d5262 - Browse repository at this point
Copy the full SHA a7d5262View commit details -
Only test node v9 and don't check coverage.
Node versions less than 9.6 do not support dynamic es imports. Currently using instanbul to calculate codecoverage calls some script without a .js file extension which causes the tests to fail. Hopefully in v9.7 this will be fixed.
Configuration menu - View commit details
-
Copy full SHA for 10736aa - Browse repository at this point
Copy the full SHA 10736aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b28d2db - Browse repository at this point
Copy the full SHA b28d2dbView commit details
Commits on Feb 27, 2018
-
Test that cjs tests still work when using es-modules.
Adds an integration test that uses cjs modules but is called with the --es-modules flag.
Configuration menu - View commit details
-
Copy full SHA for e1ad789 - Browse repository at this point
Copy the full SHA e1ad789View commit details -
Catch and report errors thrown from top level of modules.
Dynamic imports are async and therefore errors need to be explicitly handled.
Configuration menu - View commit details
-
Copy full SHA for a16f8d0 - Browse repository at this point
Copy the full SHA a16f8d0View commit details
Commits on Mar 7, 2018
-
Revert "Only test node v9 and don't check coverage."
This reverts commit 10736aa.
Configuration menu - View commit details
-
Copy full SHA for a494924 - Browse repository at this point
Copy the full SHA a494924View commit details -
Revert "Try running tests on appveyer with node v9"
This reverts commit b28d2db.
Configuration menu - View commit details
-
Copy full SHA for 666a25f - Browse repository at this point
Copy the full SHA 666a25fView commit details