Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of bareword args matching node flags; closes #3761 #3767

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

boneskull
Copy link
Contributor

maybe not the most elegant solution, but it seems to work.

cc @nknapp @Janpot

@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 25, 2019
@boneskull boneskull added this to the next milestone Feb 25, 2019
@boneskull boneskull self-assigned this Feb 25, 2019
@boneskull boneskull force-pushed the boneskull/issue/3761 branch from 410a116 to 5e7024f Compare February 25, 2019 05:07
lib/cli/node-flags.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 25, 2019

Coverage Status

Coverage increased (+0.01%) to 91.664% when pulling 5e7024f on boneskull/issue/3761 into 6535965 on master.

@boneskull boneskull force-pushed the boneskull/issue/3761 branch from 5e7024f to e91ef1c Compare February 25, 2019 17:16
@boneskull boneskull merged commit 9e31e9d into master Feb 25, 2019
@boneskull boneskull deleted the boneskull/issue/3761 branch February 25, 2019 17:17
@boneskull boneskull modified the milestones: next, v6.0.2 Feb 25, 2019
piotrwitek pushed a commit to piotrwitek/ts-mocha that referenced this pull request Feb 25, 2019
## The devDependency [mocha](https://github.com/mochajs/mocha) was updated from `6.0.1` to `6.0.2`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v6.0.2</summary>

<h1>6.0.2 / 2019-02-25</h1>
<h2><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Fixes</h2>
<p>Two more regressions fixed:</p>
<ul>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3768" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3768/hovercard">#3768</a>: Test file paths no longer dropped from <code>mocha.opts</code> (<a href="https://urls.greenkeeper.io/boneskull"><strong>@boneskull</strong></a>)</li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3767" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3767/hovercard">#3767</a>: <code>--require</code> does not break on module names that look like certain <code>node</code> flags (<a href="https://urls.greenkeeper.io/boneskull"><strong>@boneskull</strong></a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/00a895f6ad9c1e4c5500851d6ff875e8254a5e06"><code>00a895f</code></a> <code>Release v6.0.2</code></li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/1edce76eb88c2c04dee604efc10552b0a7d5e637"><code>1edce76</code></a> <code>update CHANGELOG for v6.0.2 [ci skip]</code></li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/347e9db3b40eb22bcbc23a026d9915c77040b897"><code>347e9db</code></a> <code>fix broken positional arguments in config; ensure positional args are unique; closes #3763</code></li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/9e31e9dcfd45b958aa14961f35abbff8f7ea2b1b"><code>9e31e9d</code></a> <code>fix handling of bareword args matching node flags; closes #3761</code></li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/6535965e8655a66de54fc0ad9465c2eb825f13f8"><code>6535965</code></a> <code>Update "karma-browserify" to eliminate Karma middleware warning (#3762)</code></li>
<li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/37febb62796374114d2e24534eb44f8776bc7800"><code>37febb6</code></a> <code>improve issue template. (#3411)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/mochajs/mocha/compare/6d3d6b4d5262f9d6374a887834224eb729890b4d...00a895f6ad9c1e4c5500851d6ff875e8254a5e06">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants