-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: control stringification of error message #4128
Conversation
@syeutyu could you rebase to |
I have rebased it @juergba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syeutyu thank you for this PR.
I just have two small changes, then it's ready to get merged.
@juergba I've updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syeutyu thank you
Requirements
Description of the Change
Before, The order of the previous processing is as follows
After
So developers can custom error message if they want
I have been found util.inspect.custom API, but if set up util.inspect.custom that changed error format
So this pr only change ordering with err.inspect function and err.message 😭
Benefits
Developer can custom error message handling in mocha
Applicable issues
issues:3985