Browser: fix 'allowUncaught' handling #4174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
process.on('uncaughtException', fn)
handler is moved toglobal.onerror(fn)
in Browser.allowUncaught: true
==> test results are incorrect, since the entire recovery logic of the handler is skipped.
Description of the Change
uncaughtException
whenallowUncaught
is set.uncaughtException
handler. The script keeps running and the test results are correct. SoallowUncaught
has no effect on the test run, butuncaughtException
's are printed in the console.