-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include stack in browser uncaught error reporting #5107
fix: include stack in browser uncaught error reporting #5107
Conversation
This reverts commit 30c7ffb.
thanks @JoshuaKGoldberg! |
I hadn't noticed that #5080 did this same thing. Closing in favor of that one. 🚀 |
...and, re-opening per #5080 (comment). 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should go through all the browser polyfilling eventually, but this looks good, only the sinon fix needed.
For future reference / personal reference: Related APIs:
- https://developer.mozilla.org/en-US/docs/Web/API/Window/error_event
- https://nodejs.org/api/process.html#event-uncaughtexception
Could perhaps want to move Mocha to this one eventually:
Co-authored-by: Pelle Wessman <pelle@kodfabrik.se>
This was released in |
PR Checklist
status: accepting prs
Overview
Continues #3952. In summary, this change uses the "newly" available
err
parameter inonerror
to log a nicer stack.Co-authored-by: Peter Rust peter@cornerstonenw.com