-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow ^ versions for character encoding packages #5150
Merged
JoshuaKGoldberg
merged 5 commits into
mochajs:main
from
JoshuaKGoldberg:minor-versions-character-encoding-packages
Jul 2, 2024
Merged
feat: allow ^ versions for character encoding packages #5150
JoshuaKGoldberg
merged 5 commits into
mochajs:main
from
JoshuaKGoldberg:minor-versions-character-encoding-packages
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d8af57
to
352b483
Compare
352b483
to
993c3a6
Compare
993c3a6
to
00a7f9f
Compare
voxpelli
requested changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one change looks indeed harmless: doowb/ansi-colors@4.1.1...4.1.3
But can you do a new npm install ansi-colors@^4.1.3
to ensure that our lockfile actually also references it?
JoshuaKGoldberg
commented
May 31, 2024
voxpelli
reviewed
Jun 4, 2024
Released in |
This was referenced Jul 23, 2024
This was referenced Aug 18, 2024
This was referenced Aug 18, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Adds a
^
range to the following packages related to character encoding in logs:ansi-colors
: new minor versions available, up to4.1.3
- which it's upgraded to nowbrowser-stdout
: latest version; hasn't been updated in 6 yearsescape-string-regexp
: no new minor versions available - just a new majorhe
: latest version; hasn't been updated in 6 yearslog-symbols
: no new minor versions available - just new majorssupports-color
: no new minor versions available - just a new major