Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Html pending #803

Merged
merged 3 commits into from
Aug 9, 2013
Merged

Add Html pending #803

merged 3 commits into from
Aug 9, 2013

Conversation

mazerte
Copy link

@mazerte mazerte commented Apr 10, 2013

Hi,

I add pending test in header of html reporter.
It's relative too this issues #68

Bye,
mäzèrté

@geekdave
Copy link

👍

This is a very useful feature. In my team, we have a policy of writing the test "skeletons" (pending tests) at the beginning of every sprint, based on our QA team's test cases. At the end of the sprint, if any pending tests remain, the feature is not considered complete.

With over a thousand assertions in our suite, it's not feasible to manually scroll through the report to find the pending specs. Being able to filter in the HTML report is the way to go.

Just tested this PR locally and it worked like a charm. Thanks, @mazerte !

tj added a commit that referenced this pull request Aug 9, 2013
@tj tj merged commit 985ee26 into mochajs:master Aug 9, 2013
@craig-jennings
Copy link

Why was this code removed in 1411826? Are y'all planning on adding it back in next release?

@geekdave
Copy link

geekdave commented Oct 2, 2013

@visionmedia / @travisjeffery : Was support for pending tests in the HTML report mistakenly removed? It was merged here and then removed without explanation.

@geekdave
Copy link

geekdave commented Oct 2, 2013

@travisjeffery
Copy link
Contributor

Hmm I'm not sure. I think @visionmedia may have just made a merge mistake or something.

@geekdave
Copy link

geekdave commented Oct 2, 2013

@travisjeffery thanks for looking. Would it be easiest for me to just open a new PR? Or would you suggest another approach?

@travisjeffery
Copy link
Contributor

@geekdave sure that'd be great. new pr's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants