Client unsubscribe topic have problem #349

Scorpions777 · 2023-12-19T09:02:17Z

I test in mqtt.js like below, unsubscribe thorw some exception, but it have no problem when i use emqx broker, mochi is v2.4.3 and v2.4.1

<!DOCTYPE html>
<html>

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <script src="https://unpkg.com/mqtt/dist/mqtt.min.js"></script>
</head>

<body>
    <button onclick="subscribe()">订阅</button>
    <button onclick="publish()">发布</button>
    <button onclick="unsubscribe()">取消订阅</button>
</body>
<script>
    const clientId = 'mqttjs_' + Math.random().toString(16).substr(2, 8)

    const brokerUrl = 'ws://127.0.0.1:1882'
    // const brokerUrl = 'ws://broker.emqx.io:8083/mqtt'

    const options = {
        keepalive: 60,
        clientId: clientId,
        protocolId: 'MQTT',
        protocolVersion: 4,
        clean: true,
        reconnectPeriod: 1000,
        connectTimeout: 30 * 1000,
        will: {
            topic: 'WillMsg',
            payload: 'Connection Closed abnormally..!',
            qos: 0,
            retain: false
        },
    }

    const client = mqtt.connect(brokerUrl, options)

    client.on('error', (err) => {
        console.log('Connection error: ', err)
        client.end()
    })

    client.on('reconnect', () => {
        console.log('Reconnecting...')
    })

    client.on('connect', () => {
        console.log('Client connected:' + clientId)
    })

    client.on('message', (topic, message, packet) => {
        console.log('Received Message: ' + message.toString() + '\nOn topic: ' + topic)
    })

    function publish() {
        client.publish('testtopic', 'ws connection demo...!', { qos: 0, retain: false })
    }

    function unsubscribe() {
        client.unsubscribe('testtopic')
    }

    function subscribe() {
        client.subscribe('testtopic', { qos: 0 })
    }
</script>

</html>

dadebue · 2023-12-22T15:14:11Z

I just found exactly the same problem and was about to create an issue :)

Testing with https://github.com/mqttjs/MQTT.js and v2.4.4. The thrown error from MQTT.js is:

Error: Malformed unsuback, payload length must be 2

werbenhu added a commit to werbenhu/mochimqtt that referenced this issue Dec 26, 2023

Fix mochi-mqtt#349, MQTT v3 unsuback does not require Reason Code.

9fdbe19

werbenhu mentioned this issue Dec 26, 2023

Fix #349, MQTT v3 unsuback does not require Reason Code. #353

Merged

werbenhu added the bug Something isn't working label Dec 27, 2023

mochi-co closed this as completed in #353 Jan 10, 2024

mochi-co pushed a commit that referenced this issue Jan 10, 2024

Fix #349, MQTT v3 unsuback does not require Reason Code. (#353)

10a02ab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client unsubscribe topic have problem #349

Client unsubscribe topic have problem #349

Scorpions777 commented Dec 19, 2023

dadebue commented Dec 22, 2023 •

edited

Loading

Client unsubscribe topic have problem #349

Client unsubscribe topic have problem #349

Comments

Scorpions777 commented Dec 19, 2023

dadebue commented Dec 22, 2023 • edited Loading

dadebue commented Dec 22, 2023 •

edited

Loading