Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to limit maximum number of clients #379

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Ability to limit maximum number of clients #379

merged 4 commits into from
Apr 16, 2024

Conversation

thedevop
Copy link
Collaborator

No description provided.

@thedevop thedevop requested review from mochi-co and werbenhu March 28, 2024 02:03
@coveralls
Copy link

coveralls commented Mar 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8708813224

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.707%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server.go 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
server.go 4 99.02%
Totals Coverage Status
Change from base Build 8510971796: -0.1%
Covered Lines: 6106
Relevant Lines: 6186
💛 - Coveralls

werbenhu
werbenhu previously approved these changes Mar 28, 2024
View reviewed changes
mochi-co
mochi-co requested changes Apr 1, 2024
View reviewed changes
server.go Outdated Show resolved Hide resolved
mochi-co
mochi-co approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedevop Sorry I really thought I'd approved this already. Looks great, approving and merging! Thank you

@mochi-co mochi-co merged commit cb217cd into mochi-mqtt:main Apr 16, 2024
3 checks passed
@thedevop thedevop deleted the maxclients branch April 21, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

@werbenhu werbenhu werbenhu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thedevop @coveralls @werbenhu @mochi-co