Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 0x04 Reason Code functionality #395

Merged
merged 4 commits into from
Apr 30, 2024
Merged

add 0x04 Reason Code functionality #395

merged 4 commits into from
Apr 30, 2024

Conversation

dgduncan
Copy link
Collaborator

Adds functionality for DISCONNECT REASON CODE 0x04.
This increases compliance of the SPARKPLUG B 3.0.0 specification documentation.

Sparkplug
[tck-id-payloads-ndeath-will-message-publisher-disconnect-mqtt50]

MQTT V5
[MQTT-3.1.2.5] Non-normative comment

@dgduncan dgduncan added the enhancement New feature or request label Apr 27, 2024
@dgduncan dgduncan linked an issue Apr 27, 2024 that may be closed by this pull request
Add Support for Disconnect With Will Message Reason Code #393
Closed
@coveralls
Copy link

coveralls commented Apr 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8864735244

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.675%
Files with Coverage Reduction New Missed Lines %
server.go 6 98.86%
Totals Coverage Status
Change from base Build 8708963763: -0.1%
Covered Lines: 6107
Relevant Lines: 6189
💛 - Coveralls

@dgduncan dgduncan self-assigned this Apr 28, 2024
mochi-co
mochi-co approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice and clean!

@mochi-co mochi-co merged commit 64ea905 into mochi-mqtt:main Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

@werbenhu werbenhu Awaiting requested review from werbenhu

@thedevop thedevop Awaiting requested review from thedevop

Assignees

@dgduncan dgduncan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Disconnect With Will Message Reason Code
3 participants
@dgduncan @coveralls @mochi-co