use cl.ID instead of pk.Connect.ClientIdentifier when looking for existing clients in inheritClientSession #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lied, when looking for existing clients in inheritClientSession
SimonMacIntyre
changed the title
SimonMacIntyre
changed the title
SimonMacIntyre
changed the title
|
Huh, not sure I understand the pipeline failure, the tests all worked on this locally 🤔 Anything I can do? |
Pull Request Test Coverage Report for Build 10167435003Details
💛 - Coveralls |
|
@SimonMacIntyre Looks like it was just flakey tests 👍🏻 |
thedevop
approved these changes
Jul 29, 2024
|
Nice improvement here, thank you @SimonMacIntyre :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #416
The reason I want to open this PR:
pk.Connect.ClientIdentifierin clients.go, It also is the same value as the assignedClientId if there is one. Therefore it is more correct, but also for the reasons below:cl.IDand override it and the assigned id returned to the client(I assign intentional, known, client ids to specific clients. We want to control the client ids based on the authenticating client.)All tests still pass, including the existing client takeover tests.
@mochi-co Do you think the existing tests are good for this, or do we want some kind of regression test case? I was looking at the tests to add one but to be honest, it is a bit beyond my Go skill level at the moment.