An apocalypse detector... #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…there, generator isn't.
pleroy
reviewed
Oct 18, 2016
| CHECK_NOTNULL(plugin)->HasEncounteredApocalypse(allocated_details); | ||
| *CHECK_NOTNULL(details) = allocated_details->c_str(); | ||
| CHECK_NOTNULL(plugin)->HasEncounteredApocalypse(&details_string); | ||
| UniqueBytes allocated_details(details_string.size() + 1); |
There was a problem hiding this comment.
This seems very complicated. I don't think you need allocated_details at all: just copy details_string into *details.
There was a problem hiding this comment.
Someone has to allocate something releaseable; *details may well be null.
Note that the existing code with new std::string was broken, the pointer to the string was lost and thus leaked---and then the c_str() was deallocated, which is probably UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but somehow I cannot trigger it. Fixes some issues in the interface though.
Changes to the code generator: for the changes to the output see c81f490.