Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Sep 8, 2018
| anomalous_segments_ = 1; | ||
| return; | ||
| } | ||
| // TODO(egg): move this to the Manœuvre class. |
There was a problem hiding this comment.
Please create an issue for all these TODOs.
| @@ -54,6 +55,11 @@ class Ephemeris { | |||
| using IntrinsicAcceleration = | |||
| std::function<Vector<Acceleration, Frame>(Instant const& time)>; | |||
There was a problem hiding this comment.
Do we still need the old intrinsic acceleration somewhere? If not, mention that we need to clean up in the issue.
There was a problem hiding this comment.
We still use it for the non-guided path, which uses a non-RKNG RKN.
| max_ephemeris_steps * parameters_.step(), | ||
| trajectory_last_time + parameters_.step()), | ||
| t); | ||
| Prolong(t_final); |
There was a problem hiding this comment.
I am sure that I have seen most of this code elsewhere. Please factor it out.
pleroy
added a commit
that referenced
this pull request
Dec 2, 2018
Start fixing the debt introduced in #1930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1909.