Propagate errors found during integration to kill the vessel #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any error found during integration of the pile-up.
eggrobin
approved these changes
Jan 13, 2019
ksp_plugin/plugin.cpp
Outdated
| << " collided with a celestial"; | ||
| LOG(WARNING) << "Vessel " << vessel->ShortDebugString() | ||
| << " collided with a celestial: " | ||
| << future.get().ToString(); |
There was a problem hiding this comment.
We cannot call future.get() twice, see https://en.cppreference.com/w/cpp/thread/future/get:
The behavior is undefined if
valid()isfalsebefore the call to this function.
Any shared state is released.valid()isfalseafter a call to this method.
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help with #2056 but I don't have an easy way to test. There will be a message in the WARNING log to see if we are properly handling the condition.