A more stable angular momentum correction. #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Apr 17, 2020
ksp_plugin/pile_up.cpp
Outdated
| actual_equivalent_angular_velocity, | ||
| actual_pile_up_equivalent_rotation.Forget<OrthogonalMap>()), | ||
| correct_angular_velocity ? actual_equivalent_angular_velocity | ||
| : NonRotatingPileUp::nonrotating, |
| << actual_equivalent_angular_velocity.Norm() / | ||
| (2 * π * Radian / quantities::si::Minute) | ||
| << " rpm\n" | ||
| << (correcting_orientation ? "CORRECTING ORIENTATION" : u8"—"); |
This was referenced Apr 17, 2020
pleroy
approved these changes
Apr 18, 2020
|
Tested the binaries in KSP v1.8.1 in a mess of an RP-1 career/dev mod environment. Thanks to egg for providing them. Results: https://gfycat.com/jubilantmeaslydartfrog Report:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to significantly improve the behaviour reported in #2519.
It is not perfect. In the save from #2519 (comment), while we get no uncontrolled spin-up, we get more oscillations than in stock, slowing the rocket down, so that it reaches the water without burning up.
Note that this adds back some traces and toggles for debugging. They will be hidden in a separate pull request (but I would like to keep the plumbing around for now; we may not be quite done with this issue yet).