Add a C# class PrincipiaTimeSpan to gather time formatting and parsing #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
reviewed
Apr 21, 2020
ksp_plugin_adapter/time_span.cs
Outdated
| } | ||
|
|
||
| public static int day_duration => date_time_formatter.Day; | ||
| public static string day_symbol => is_stock_day ? "d6" : "d"; |
There was a problem hiding this comment.
public static string day_symbol =>
hour_divides_day && !is_si_time
? "d" + (int)(date_time_formatter.Day / date_time_formatter.hour)
: "d";
private static bool hour_divides_day =>
(int)(date_time_formatter.Day / date_time_formatter.hour) * date_time_formatter.hour ==
date_time_formatter.Day;
private static is_si_time =>
date_time_formatter.Minute == 60 &&
date_time_formatter.Hour == 60 * 60 &&
date_time_formatter.Day == 24 * 60 * 60;There was a problem hiding this comment.
Actually I made the change, and I found the output with JNSQ unnecessarily noisy:
014 d12 00 h 00 min
So I changed it again to only display one digit after d. Thus d3, d6, d9 but just d for JNSQ.
eggrobin
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it use the correct KSP APIs to figure out the length of the day, etc. Tested in game with stock and JNSQ.
Fix #2520.