Three new API functions #2566
Merged
Three new API functions #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
May 12, 2020
ksp_plugin/interface_external.cpp
Outdated
| return m.Return( | ||
| MakeStatus(Error::INVALID_ARGUMENT, "|plugin| must not be null")); | ||
| } | ||
| Instant const t = FromGameTime(*plugin, time); |
There was a problem hiding this comment.
Move down, closer to the place where you need it.
ksp_plugin/interface_external.cpp
Outdated
| return m.Return( | ||
| MakeStatus(Error::INVALID_ARGUMENT, "|plugin| must not be null")); | ||
| } | ||
| Instant const t = FromGameTime(*plugin, time); |
There was a problem hiding this comment.
Move down, closer to the place where you need it.
ksp_plugin/interface_external.cpp
Outdated
| return m.Return( | ||
| MakeStatus(Error::INVALID_ARGUMENT, "|plugin| must not be null")); | ||
| } | ||
| Instant const t = FromGameTime(*plugin, time); |
There was a problem hiding this comment.
Move down, closer to the place where you need it.
ksp_plugin/interface_external.cpp
Outdated
| .str())); | ||
| } | ||
| using Surface = Frame<enum class SurfaceTag>; | ||
| auto const to_world_axes = |
There was a problem hiding this comment.
Use a real type instead of auto.
|
retest this please |
SirMortimer
added a commit
to Kerbalism/Skopos
that referenced
this pull request
May 18, 2020
Using the API requested with mockingbirdnest/Principia#2542 and added with mockingbirdnest/Principia#2566 Extracted the body, waypoint and vessel calculation shenanigans into a delegate Added a delegate with principia implementation and using that in case principia is detected
SirMortimer
added a commit
to Kerbalism/Skopos
that referenced
this pull request
May 20, 2020
Principia doesn't guarantee that the values in the object passed from within the realms of it's inconceivable depths are, or will remain to be, fields or properties. So use the reflection method from their wiki, and care about possible performance considerations later. See also mockingbirdnest/Principia#2566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2542.
Tested in-game; if we want to add the test utility (a separate DLL which just calls those endpoints by reflection and dumps the output or exceptions to a window) we should do it in a separate pull request.
Note that despite the work on the UTF-8 marshalers we still lack the capability to produce strings as struct fields, so Status still lacks a message. This may be a lower-hanging fruit than it was when that TODO was written though.