A mechanism for prepending a Forkable to another Forkable #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
requested changes
Sep 5, 2021
physics/forkable.hpp
Outdated
| // the structure of the various trajectories (that's the case in tests). | ||
| // This trajectory is still a valid pointer, but it may now be owned by the | ||
| // parent of T. The only pointer that the client might assume to own is | ||
| // this->root(). |
There was a problem hiding this comment.
Let’s make this a static method that takes both roots by unique_ptr as well as a pointer to trajectory (whose root must be the prepended one), and returns whichever unique_ptr remains; taking ownership of this is a bad idea (and likewise for trajectory->root()), and having a unique_ptr to the non-const root of trajectory will ensure that the const_cast in the implementation does not introduce UB.
eggrobin
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very boring part of #2400.