Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: simplify trellis installation and move to image-to-3d #1023

Closed
wants to merge 30 commits into from
Closed

cleanup: simplify trellis installation and move to image-to-3d #1023

wants to merge 30 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Clean up the installation process for the TRELLIS example:

  • Consolidate pip install steps into single command
  • Pin all package versions
  • Update to CUDA 12.4 base image
  • Remove unnecessary environment variables
  • Move file to proper directory structure

Link to Devin run: https://app.devin.ai/sessions/ccc690aa72da4a67b1e27aae868e9f45

@devin-ai-integration @charlesfrye
cleanup: simplify trellis installation and move to image-to-3d
c6c3597 
- Consolidate pip install steps and pin versions
- Update to CUDA 12.4 base image
- Remove unnecessary environment variables
- Move file to 06_gpu_and_ml/image-to-3d directory

Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@devin-ai-integration @charlesfrye
style: apply ruff formatting to trellis3d.py
de67eee 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-a5707b5.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-9970b4e.modal.run

@devin-ai-integration @charlesfrye
fix: add proper command entrypoint for CI
f732757 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-86f1da3.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 15:45
@devin-ai-integration @charlesfrye
fix: remove app.command() and if-main block
0596970 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: add frontmatter to specify test method for CI
6670c53 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-39e9d0b.modal.run

@devin-ai-integration @charlesfrye
refactor: switch to app.local_entrypoint and remove test method
c5f1547 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-88e4d1d.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-6b34f0d.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 16:09
@devin-ai-integration @charlesfrye
fix: implement multi-step installation with CUDA support for flash-attn
b21444d 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: improve pytorch and kaolin installation order and dependencies
b9942b4 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-3eeb416.modal.run

@devin-ai-integration @charlesfrye
fix: update file handling and fix import sorting
3924a3f 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-a8540f7.modal.run

@devin-ai-integration @charlesfrye
fix: improve local_entrypoint and parameter handling
0fca476 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-5629818.modal.run

@devin-ai-integration @charlesfrye
fix: update torch version to match torchvision requirements
009acd3 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-ac66caa.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-0238ec9.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 16:35
@devin-ai-integration @charlesfrye
fix: reorganize kaolin installation steps and pin dependency versions
badeafb 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: resolve ruff linting issues with os import
8dd1577 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye charlesfrye mentioned this pull request Dec 18, 2024
Merged
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-d6de9a3.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 16:40
@devin-ai-integration @charlesfrye
style: apply ruff formatting
261e17d 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: improve file handling with Path and write_bytes
8a288a9 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-6b82485.modal.run

@devin-ai-integration @charlesfrye
fix: remove unused imports to fix ruff linting
464b887 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-f668548.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-175bb77.modal.run

devin-ai-integration bot and others added 3 commits December 18, 2024 16:58
@devin-ai-integration @charlesfrye
fix: update installation steps and standardize CUDA versions
1fdb5ff 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
style: apply ruff formatting
633238a 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: update pytorch installation parameter to use extra_index_url
87536bf 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-777df1e.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-8a9f133.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-93708f8.modal.run

@devin-ai-integration @charlesfrye
fix: add requests package to core dependencies
f37b350 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-f1f006f.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 17:30
@devin-ai-integration @charlesfrye
fix: update PYTHONPATH configuration and simplify installation steps
6a778a0 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
style: fix import sorting and remove unused imports
9e9b9fa 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-4d3b7b4.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-b104b87.modal.run

@devin-ai-integration @charlesfrye
feat: implement proper file output handling with Path and write_bytes
5927942 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-ce5f8ad.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 17:52
@devin-ai-integration @charlesfrye
fix: update CUDA version to 12.4 and improve file handling
094c13c 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
style: remove unused io import
1a30985 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-3c5749b.modal.run

@devin-ai-integration @charlesfrye
style: apply ruff formatting
8463779 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-da0f485.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-cff4491.modal.run

devin-ai-integration bot and others added 2 commits December 18, 2024 18:08
@devin-ai-integration @charlesfrye
fix: update pytorch installation format for CUDA 12.4
573d410 
Co-Authored-By: Charles Frye <charles@modal.com>
@devin-ai-integration @charlesfrye
fix: update TRELLIS pipeline usage and improve file handling
648f1af 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-9b7bf74.modal.run

@devin-ai-integration @charlesfrye
style: clean up logging and comments
b1175eb 
Co-Authored-By: Charles Frye <charles@modal.com>
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-e0839b7.modal.run

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-5291e6d.modal.run

@charlesfrye charlesfrye closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charlesfrye