This is related to #487, which is now closed.

[paulredman-]

Describe the issue
When setting a GenericForeignKey to None, the component parts are created.

To Reproduce

Definition for comms.Message

relates_to_id = models.PositiveIntegerField(null=True, blank=True)
relates_to_type = models.ForeignKey(ContentType, null=True, blank=True, on_delete=models.PROTECT)
relates_to = GenericForeignKey('relates_to_type', 'relates_to_id')

# Failing test code
    from_message = baker.make(
        'comms.Message', _fill_optional=True, from_user=lawyer.user, to_user=client.user, relates_to=None
    )

    self.assertIsNone(from_message.relates_to)

    # These two both fail with model_bakery==1.19.4
    self.assertIsNone(from_message.relates_to_type_id)
    self.assertIsNone(from_message.relates_to_id)

Expected behavior
If relates_to is set to None, then relates_to_id and relates_to_type_id are both set to None for a GenericForeignKey

Versions
1.19.4

• Python: [e.g. 3.10]
• Django [e.g. 4.1]
• Model Bakery [e.g. 1.6.0]

Rust,
I'd appreciate your thoughts on this. We could set relates_to_id and relates_to_type_id explicitly to None in our code, but I'm not sure this is the right answer. Please let me know if you need any more information on this to help diagnose the problem.

[amureki]

Hey Paul!

I agree that this should be solved by the library and not by manually updating all the places using GFKs.
I am adjusting the logic in #499 to handle this behaviour.

[paulredman-]

Hi Rust Once again, many thanks!! Best,Paul On Friday, 23 August 2024 at 14:29:31 BST, Rust Saiargaliev ***@***.***> wrote: Hey Paul! I agree that this should be solved by the library and not by manually updating all the places using GFKs. I am adjusting the logic in #499 to handle this behaviour. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[paulredman-]

Rust Many thanks, once again. Paul On Monday, 26 August 2024 at 07:44:22 BST, Rust Saiargaliev ***@***.***> wrote: Closed #498 as completed via 8b60451. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>