Downgrade the toolchain to avoid blocking issue #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigates model-checking#1822 which is caused by rust-lang/rust#103814. Ps.: I also bumped cbmc min version since older versions don't work with Kani.
tedinski
approved these changes
Nov 1, 2022
tedinski
reviewed
Nov 1, 2022
| @@ -22,7 +22,7 @@ KANI_DIR=$SCRIPT_DIR/.. | |||
| export KANI_FAIL_ON_UNEXPECTED_DESCRIPTION="true" | |||
|
|
|||
| # Required dependencies | |||
| check-cbmc-version.py --major 5 --minor 67 | |||
| check-cbmc-version.py --major 5 --minor 69 | |||
There was a problem hiding this comment.
I was just running into this (without updating cbmc you get a weird goto-cc failure in the test suite) so glad you snuck this in.
zhassan-aws
approved these changes
Nov 1, 2022
Bad luck, I guess... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Downgrade the rust toolchain for the nighly before the current version. This mitigates #1822 which is caused by rust-lang/rust#103814.
Ps.: I also bumped cbmc min version since older versions don't work with Kani.
Resolved issues:
Mitigates #1822
Related RFC:
N/A
Call-outs:
Testing:
How is this change tested? New test + manually tested against s2n-quic.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.