Remove --legacy-linker support
#2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the firecracker codegen test to use `cargo kani assess` instead and I removed the old scripts to collect info on the top X crates since we no longer use them. I kept the compiler option `--reachability=legacy` since we still use it to test the std library code generation. I also kept the `--mir-linker` option as a no-op for now.
zhassan-aws
approved these changes
Jan 17, 2023
tedinski
approved these changes
Jan 17, 2023
| # Use the legacy linker for now since we want to maximize the code that we are compiling from firecracker. | ||
| # The MIR Linker will by default only collect code relevant to proof harnesses, however, firecracker has none. | ||
| cargo kani --only-codegen --legacy-linker | ||
| # Use cargo assess since this is now our default way of assessing Kani suitability to verify a crate. |
There was a problem hiding this comment.
Not for this PR, but think we should do this for std too? (Or did we already and I missed it...)
There was a problem hiding this comment.
We haven't. I added a note to the description of the PR.
I don't know how easy it would be to compile the tests of the std library without the bootstrap script. We currently rely on the special cargo support to build the standard library. So even just building the standard library as part of cargo kani flow would require a way to extend our cargo call to include the -Z build-std.
tedinski
reviewed
Jan 17, 2023
tedinski
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I updated the firecracker codegen test to use
cargo kani assessinstead and I removed the old scripts to collect info on the top X crates since we no longer use them.I kept the compiler option
--reachability=legacysince we still use it to test the std library code generation. I also kept the--mir-linkeroption as a no-op for now.Resolved issues:
Fixes #2126
Related RFC:
N/A
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.