Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on concrete playback inplace #2454

Merged
merged 1 commit into from
May 19, 2023

Conversation

celinval
Copy link
Contributor

Description of changes:

This fixes a regression from #2439. The compiler should store the location of the function body instead of the declaration. Storing the correct location fixes how concrete playback stores the generated unit test.

Resolved issues:

Resolves #2450

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

I'm planning to add an end to end case to avoid regressions like this as we introduce the playback subcommand.

Testing:

  • How is this change tested? Manually

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner May 19, 2023 04:39
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@celinval celinval merged commit 19b7a7d into model-checking:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concrete Playback=inplace produces unit test inside the harness
2 participants