-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free up additional disk space on GitHub runner #2674
Conversation
Our releasebundle-ubuntu action occasionally failed for it ran out of disk space. (See https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703 for one such example. This additional build step cleans out binaries that we do not need, such as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of a total of 84 GB).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we should add this new step to the setup action instead, so most of our jobs would benefit from this cleanup.
Done. |
I agree with @zhassan-aws that this is too aggressive. We shouldn't need 28GB ever, and it's good to have less space than that so we can notice performance regressions in the future. |
I'm now more conservative in what is being removed. |
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Description of changes:
Our releasebundle-ubuntu action occasionally failed for it ran out of disk space. (See
https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703 for one such example.
This additional build step cleans out binaries that we do not need, such as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of a total of 84 GB).
Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? CI
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.