Upgrade Rust toolchain to nightly-2024-01-23 #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is due to the safety fix to the internal function, which was
done here: rust-lang/rust#120128
celinval
changed the title
Dependency upgrade resulting from `cargo update`. Co-authored-by: tautschnig <tautschnig@users.noreply.github.com>
These are the auto-generated release notes for comparison purposes: ## What's Changed * Rethink `should_panic` and `fail_uncoverable` options as global conditions by @adpaco-aws in model-checking#2967 * Upgrade toolchain to nightly-2024-01-17 by @celinval in model-checking#2976 * Benchcomp visualize: fix missing import by @tautschnig in model-checking#2977 * Cargo update 2024-01-18 by @remi-delmas-3000 in model-checking#2978 **Full Changelog**: model-checking/kani@kani-0.44.0...kani-0.45.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Make __kani__workaround_core_assert public in lib.rs
zhassan-aws
approved these changes
Jan 26, 2024
|
Some perf benchmarks regress from success to failure. We should not merge this PR until we fix them. |
|
I did a quick research, the loop unwind assertion fails in function: ... My hypothesis is that the change in behavior we are seeing is due to rust-lang/rust#111803 where the threshold for calling nonoverlapping swap changed. Increasing the unwind limit seems to suffice to fix most harnesses. Unfortunately, |
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Feb 3, 2024
I tried applying model-checking#2983 fix, however, this would require user to import `__kani_workaround_core_assert`. To fix that, I moved the definition to be under `kani` crate.
tautschnig
pushed a commit
that referenced
this pull request
Feb 5, 2024
I tried applying #2983 fix, however, this would require user to import `__kani_workaround_core_assert`. To fix that, I moved the definition to be under `kani` crate. I replaced the existing fixme test. Initially I didn't check we had one, and I created a second one which is simpler (no cargo needed) but that also includes other cases. Resolves #2187
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Some change has dramatically increase the memory usage for this harness. For now, we should include this harness in the list of slow tests until we are able to identify the cause. We also fix the unwind in the remaning harnesses. Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
feliperodri
approved these changes
Feb 8, 2024
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try upgrading Rust toolchain to 2024-01-22, however, regression isn't working yet due to an issue with our assertion override hack. Related PRs so far:
track_errorsusages with bubbling upErrorGuaranteedrust-lang/rust#119869Resolves #ISSUE-NUMBER
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.