Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rust toolchain to nightly-2024-06-11 #3225

Merged
merged 22 commits into from
Jun 11, 2024

Conversation

tautschnig
Copy link
Member

@tautschnig tautschnig commented Jun 4, 2024

Changes required due to:

Resolves: #3218

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Changes required due to:
- rust-lang/rust@a34c26e7ec Make body_owned_by return the body directly.
- rust-lang/rust@333458c2cb Uplift TypeRelation and Relate
- rust-lang/rust@459ce3f6bb Add an intrinsic for `ptr::metadata`

Resolves: model-checking#3218
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Jun 4, 2024
@tautschnig tautschnig changed the title Update the rust toolchain to nightly-2024-06-04 Update the rust toolchain to nightly-2024-06-05 Jun 5, 2024
@tautschnig tautschnig changed the title Update the rust toolchain to nightly-2024-06-05 Update the rust toolchain to nightly-2024-06-07 Jun 7, 2024
@tautschnig tautschnig changed the title Update the rust toolchain to nightly-2024-06-07 Update the rust toolchain to nightly-2024-06-08 Jun 8, 2024
@tautschnig tautschnig marked this pull request as ready for review June 8, 2024 04:54
@tautschnig tautschnig requested a review from a team as a code owner June 8, 2024 04:54
@tautschnig tautschnig changed the title Update the rust toolchain to nightly-2024-06-08 Update the rust toolchain to nightly-2024-06-10 Jun 10, 2024
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please also add tests for ptr_metadata for the other types of pointers? Like &dyn T and &char? Thanks!

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the thin pointer case needs to be handled. Please double check

@celinval
Copy link
Contributor

Ah... That's because we skip statements that generate zst values. It does make me wonder if that's appropriate. But that's a different problem. Thanks @tautschnig

@tautschnig tautschnig changed the title Update the rust toolchain to nightly-2024-06-10 Update the rust toolchain to nightly-2024-06-11 Jun 11, 2024
@tautschnig tautschnig merged commit e922d73 into model-checking:main Jun 11, 2024
22 of 23 checks passed
@tautschnig tautschnig deleted the toolchain-2024-06-04-manual branch June 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2024-05-29 failed
3 participants