-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-upload macOS ARM binaries to draft release #3320
Conversation
In model-checking#3266 a job to build macOS ARM binaries was added, but the artifacts weren't yet propagated to the release. This PR adds this missing step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you. Is there any way of testing that this works?
Looks we are also caught by actions/checkout#1809 |
Not an easy one that I know of, I'm afraid. |
It's not easy to test but also not the end the of the world if it fails for any reason. In that case, one only needs to go the Release Bundle summary (e.g., this one for version 0.53.0), then download and attach the missing bundles to the release. |
Wait, is there a reason why we are not running any test in the image like we do with the other images? |
We could certainly add such tests, but that wouldn't in itself test that the release auto-upload works. |
No, but it would test the image which I think is more important. |
Thanks @tautschnig for adding this! 😃
@celinval I've opened #3331 to keep track of that work. Please feel free to comment if I missed something. |
In #3266 a job to build macOS ARM binaries was added, but the artifacts weren't yet propagated to the release. This PR adds this missing step.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.