-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Allow use of node16
for release jobs
#3322
Conversation
Looks like the CI job also fails with v4 😢 |
Tried adding the following to the env:
ACTIONS_RUNNER_FORCED_INTERNAL_NODE_VERSION: node16
ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16 But it didn't work. Not sure how to export these variables before starting the runners in our case. |
Replacing the action used in the |
I've also tried to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving except the PR title now needs adjusting.
Maybe worth adding a link to https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ to the PR description (and, thus, the git commit message). |
node16
for release jobs
Note: @tautschnig told us this didn't work because v4 will always try to use
Yes, added the link. Thanks! |
actions/checkout@v3 is causing trouble in the
BuildBundle-Linux
workflow as described in #3321 .This PR sets
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
to continue usingnode16
so we don't find issues withnode20
dependencies inubuntu-18.04
jobs. This is the option recommended in this GitHub post: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/Resolves #3321
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.