Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Allow use of node16 for release jobs #3322

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Jul 3, 2024

actions/checkout@v3 is causing trouble in the BuildBundle-Linux workflow as described in #3321 .

This PR sets ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true to continue using node16 so we don't find issues with node20 dependencies in ubuntu-18.04 jobs. This is the option recommended in this GitHub post: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Resolves #3321

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner July 3, 2024 21:03
@adpaco-aws
Copy link
Contributor Author

Looks like the CI job also fails with v4 😢

@adpaco-aws
Copy link
Contributor Author

Tried adding the following to the build_bundle_linux job:

  env:
    ACTIONS_RUNNER_FORCED_INTERNAL_NODE_VERSION: node16
    ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16

But it didn't work. Not sure how to export these variables before starting the runners in our case.

@adpaco-aws
Copy link
Contributor Author

adpaco-aws commented Jul 8, 2024

Replacing the action used in the build_bundle_linux job with taiki-e/checkout-action@v1 (a 3rd party action that doesn't use node) avoids the error until the actions/upload-artifact action is called because it uses the same dependencies (see this run for example).

@adpaco-aws
Copy link
Contributor Author

I've also tried to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true at the workflow level (as suggested by this comment) but it didn't work (see run here).

Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving except the PR title now needs adjusting.

@tautschnig
Copy link
Member

Maybe worth adding a link to https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ to the PR description (and, thus, the git commit message).

@adpaco-aws adpaco-aws changed the title CI: Upgrade to checkout action v4 CI: Allow use of node16 for release jobs Jul 8, 2024
@adpaco-aws
Copy link
Contributor Author

I've also tried to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true at the workflow level (as suggested by actions/checkout#1809 (comment)) but it didn't work (see run here).

Note: @tautschnig told us this didn't work because v4 will always try to use node20. The flag works if we don't upgrade the action's version.

Maybe worth adding a link to https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ to the PR description (and, thus, the git commit message).

Yes, added the link. Thanks!

@adpaco-aws adpaco-aws merged commit 107daa7 into model-checking:main Jul 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildBundle-Linux CI jobs are failing with version GLIBC_2.28 not found
2 participants