Report results as UNDETERMINED instead of SUCCESS if an unwinding assertion fails #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
force-pushed
the
insufficient-unwind-report
branch
from
1ca76d2
to
4e8ce4a
Compare
jaisnan
reviewed
Mar 4, 2022
tests/expected/unwind_tip/expected
Outdated
| @@ -1,2 +1,3 @@ | |||
| UNDTERMINED | |||
zhassan-aws
force-pushed
the
insufficient-unwind-report
branch
from
4e8ce4a
to
3250341
Compare
tedinski
approved these changes
Mar 4, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When an insufficient unwind value is specified and an unwinding assertion fails, Kani may report some checks as "SUCCESS" even though they may fail with a larger unwinding. To prevent giving this somewhat misleading result to the user, Kani will now report UNDETERMINED instead of SUCCESS if any unwinding assertion fails. The unwind tip that also gets emitted when an unwinding assertion fails:
should prompt the user to increase the unwind value.
Resolved issues:
Resolves #746
Call-outs:
Testing:
How is this change tested? Added one test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.