fix: MPS constraints weren't evaluated for wrapper actions

modelix · May 2, 2024 · 483596c · 483596c
1 parent fea10d3
commit 483596c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...ional-editor-ssr-mps/src/main/kotlin/org/modelix/editor/ssr/mps/ModelixSSRServerForMPS.kt b/...ional-editor-ssr-mps/src/main/kotlin/org/modelix/editor/ssr/mps/ModelixSSRServerForMPS.kt
@@ -291,9 +291,12 @@ object MPSConstraints : IConstraintsChecker {
         // Constraints only prevent creating a node. If it already exists, it's handled by the model checker.
         if (node.getNode() != null) return emptyList()
 
-        val parentNode = node.getParent()?.getNode().toMPS()
-        // MPS doesn't support constraint checking without a parent node
-        if (parentNode == null) return emptyList()
+        // Correct would be `parentNode = node.getParent()?.getNode().toMPS()`
+        // but the parent node is not allowed to be null.
+        // MPS itself then just passes the nearest existing ancestor to the constraints.
+        // Without this hack we cannot evaluate any constraints and there would be too many incorrect entries in the
+        // code completion menu.
+        val parentNode = node.getExistingAncestor().toMPS()
 
         // ConstraintsCanBeFacade.checkCanBeRoot()