Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding gomoku example #103

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Adding gomoku example #103

merged 9 commits into from
Mar 27, 2024

Conversation

ZiTao-Li
Copy link
Collaborator

@ZiTao-Li ZiTao-Li commented Mar 26, 2024 •
edited by DavdGao
Loading

Description

The code is contributed by Hongyi.

This example in the notebook is building Gomoku (五子棋) with AgentScope framework.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

DavdGao
DavdGao reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

PS:

  1. Please follow the naming rule and rename the example dir into game_gomoku
  2. Provide complete and executable code under a code directory.
  3. Please unify language used in this example (Currently English and Chinese are mixed.)

examples/gomoku/gomoku_examples.ipynb Outdated Show resolved Hide resolved
examples/gomoku/gomoku_examples.ipynb Outdated Show resolved Hide resolved
@DavdGao DavdGao added the new example New example label Mar 26, 2024
pan-x-c
pan-x-c approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 9a587b3 into modelscope:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

Assignees
No one assigned
Labels
new example New example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZiTao-Li @pan-x-c @DavdGao