Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download_from_url service function #140

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Apr 4, 2024

Description

  1. Rename web_search dir into web
  2. Add download_from_url service function
  3. Fix import error in distributed search example

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao requested review from pan-x-c and ZiTao-Li April 4, 2024 00:47
@DavdGao DavdGao added new service New service function ready for review labels Apr 4, 2024
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a unit test to cover the download service?

src/agentscope/service/web/download.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	docs/sphinx_doc/zh_CN/source/tutorial/204-service.md
@DavdGao DavdGao merged commit b83bbb9 into modelscope:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants