Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more service functions #156

Merged
merged 20 commits into from
Apr 23, 2024
Merged

Conversation

garyzhang99
Copy link
Collaborator

@garyzhang99 garyzhang99 commented Apr 12, 2024


name: Pull Request
about: Create a pull request

Description

Expand service functions for better agent ability

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@garyzhang99 garyzhang99 self-assigned this Apr 12, 2024
@garyzhang99 garyzhang99 changed the title [WIP] Add more service functions Add more service functions Apr 18, 2024
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

src/agentscope/service/execute_code/exec_shell.py Outdated Show resolved Hide resolved
src/agentscope/service/file/common.py Outdated Show resolved Hide resolved
src/agentscope/service/file/common.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit c101ec4 into modelscope:main Apr 23, 2024
4 checks passed
rayrayraykk added a commit to rayrayraykk/AgentScope that referenced this pull request Apr 24, 2024
…rrent_directory service functions (modelscope#156)"

This reverts commit c101ec4.
pan-x-c pushed a commit to pan-x-c/AgentScope that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants