Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify flask services #172

Merged
merged 5 commits into from
Apr 28, 2024
Merged

Modify flask services #172

merged 5 commits into from
Apr 28, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Apr 23, 2024

Description

Modify setup_hf_service.py and setup_ms_service.py to support chat models.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

rayrayraykk
rayrayraykk reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and can you please update the tutorial accordingly?

ZiTao-Li
ZiTao-Li reviewed Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to modify examples/model_configs_template/postapi_model_config_template.json as well?
Other parts LGTM.

ZiTao-Li
ZiTao-Li approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiTao-Li ZiTao-Li merged commit 5236126 into modelscope:main Apr 28, 2024
5 checks passed
@qbc2016 qbc2016 deleted the dev_script branch August 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayraykk rayrayraykk rayrayraykk left review comments

@ZiTao-Li ZiTao-Li ZiTao-Li approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbc2016 @rayrayraykk @ZiTao-Li