Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DBLP Search Functionality #177

Merged
merged 7 commits into from
May 9, 2024
Merged

Implement DBLP Search Functionality #177

merged 7 commits into from
May 9, 2024

Conversation

PengHongyiNTU
Copy link
Contributor

name: Pull Request
about: Create a pull request

Description

This PR introduces the DBLP search functionality to our application, allowing users to search f through the DBLP API.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

DavdGao
DavdGao reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline comments and add this service function to __all__ in service/__init__.py

src/agentscope/service/web/search.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments and solve the conflicts, and others lgtm.

src/agentscope/service/web/dblp.py Outdated Show resolved Hide resolved
src/agentscope/service/web/dblp.py Outdated Show resolved Hide resolved
src/agentscope/service/web/dblp.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update services in tutorial docs: docs/sphinx_doc/en/source/tutorial/204-service.md and docs/sphinx_doc/zh_CN/source/tutorial/204-service.md. Others lgtm

DavdGao
DavdGao approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 3ea22a3 into modelscope:main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PengHongyiNTU @DavdGao