Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displaying cycle dots before agent reply in AS studio #179

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Apr 25, 2024

Description

Add a decorator to the reply function. In AS studio, each agent will loop through “....” before replying, indicating that it is thinking.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reset global var in reset_glb_var().

src/agentscope/agents/user_agent.py Outdated Show resolved Hide resolved
@pan-x-c
Copy link
Collaborator

pan-x-c commented Apr 25, 2024

Using decorators on the reply method will reduce execution efficiency.

src/agentscope/agents/agent.py Outdated Show resolved Hide resolved
src/agentscope/agents/agent.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiTao-Li ZiTao-Li merged commit ac23f9a into modelscope:main Apr 26, 2024
4 checks passed
pan-x-c pushed a commit to pan-x-c/AgentScope that referenced this pull request Apr 26, 2024
…#179)

* add cycle dots before agent reply in AS studio

* change name of decorator, change type of glb_doing_signal_dict

* add refresh after reset

* decorator for reply

* init glb_doing_signal_dict

* remove js in reset_button.click since it does not work
@qbc2016 qbc2016 deleted the dev_dot branch August 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants