Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add as_server command and add server_id #211

Merged
merged 16 commits into from
May 17, 2024
Merged

Add as_server command and add server_id #211

merged 16 commits into from
May 17, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented May 10, 2024 •
edited
Loading

Description

  1. Extract the agent server related modules from the rpc_agent.py into agentscope.server package(launcher.py and servicer.py)
  2. Add as_server command to setup.py
  3. Add server_id to identify a server instance
  4. update the distribution part of the tutorial

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c self-assigned this May 10, 2024
@pan-x-c pan-x-c changed the title Add server id Add as_server command and add server_id May 10, 2024
DavdGao
DavdGao reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments

docs/sphinx_doc/en/source/tutorial/208-distribute.md Show resolved Hide resolved
src/agentscope/server/__init__.py Outdated Show resolved Hide resolved
docs/sphinx_doc/en/source/tutorial/208-distribute.md Show resolved Hide resolved
DavdGao
DavdGao reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments.

src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/launcher.py Outdated Show resolved Hide resolved
src/agentscope/server/servicer.py Outdated Show resolved Hide resolved
src/agentscope/server/servicer.py Outdated Show resolved Hide resolved
docs/sphinx_doc/en/source/tutorial/208-distribute.md Show resolved Hide resolved
DavdGao
DavdGao approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 93adc0c into modelscope:main May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@xieyxclack xieyxclack Awaiting requested review from xieyxclack

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

Assignees

@pan-x-c pan-x-c

Labels
feature ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-x-c @DavdGao