Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine prompt for werewolf games #267

Merged
merged 1 commit into from
May 31, 2024
Merged

refine prompt for werewolf games #267

merged 1 commit into from
May 31, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented May 29, 2024

Description

  1. change "speak" to "vote" when in the voting phase
  2. change "Player" to "P[p]layer" for the Regular Expression

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@qbc2016 qbc2016 requested a review from DavdGao May 29, 2024 10:08
@rayrayraykk
Copy link
Collaborator

LGTM

DavdGao
DavdGao approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 6f31cd4 into modelscope:main May 31, 2024
4 checks passed
@qbc2016 qbc2016 deleted the dev_werewolf_enhance branch August 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbc2016 @rayrayraykk @DavdGao