Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the game proceeds smoothly when some players declare abstentio… #272

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

AskyJx
Copy link
Contributor

@AskyJx AskyJx commented Jun 2, 2024

…n or remain silent during the voting phase, for example, in the 32b version of qwen1.5.


name: Pull Request
about: Create a pull request

Description

Background:Sometimes game proceeds not that smoothly when some players declare abstention or remain silent during the voting phase, for example, in the 32b version of qwen1.5.

Purpose:To ensure the game proceeds smoothly when some players declare abstention or remain silent

Changes made: Added specific logic to handle the abstention made by player in voting phase.

How to test this PR: Set Qwen1.5 32b as werewolves agent's base model.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

…n or remain silent during the voting phase, for example, in the 32b version of qwen1.5.
Copy link
Contributor Author

@AskyJx AskyJx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes reviewed

@DavdGao DavdGao requested a review from qbc2016 June 5, 2024 03:53
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It looks good to me.

@DavdGao DavdGao merged commit 580e2f8 into modelscope:main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants